Remove obsolete/experimental pandoc package #1616
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another clean-up proposal, but I kept its separate from #1610 because the things at stakes are a bit different and I want to take the time properly advocating and discussing.
Rationale for removal
This being said in good faith, do not misunderstand me, the very idea was clever. Especially the "mapping between the Pandoc AST and SILE commands" - This is what made me think having Pandoc in the loop is indeed quite unavoidable for some things: whatever efforts we could do to improve Lunamark for the "native" route, it's quite probably (and reasonably fair) that it will never fully cope up with Pandoc's myriad of options and extensions... And that working something out directly from the Pandoc AST could be worth trying, alleviating the need for a specific build of Pandoc: hence the "alternate" pandocast approach in my markdown.sile work. It's not perfect: It still naturally imposes efforts when/if the Pandoc AST evolves, but at least it's on one side only.
Rationale for keeping ('cause there must be one, indeed interesting)
My above-mentioned "markdown.sile" solutions, be it under the form of an overhaul of the "native" Lunamark-based reader or of the Pandoc AST parsing route, both generate directly a PDF from a Markdown file provided to SILE. The approach here, generating some kind of SIL-language intermediate output - Pandoc being just a converter here - allows one to easily tweak the result before processing it with SILE.
This being said, a nicer option IMHO (which may be generalized to other format inputters) would be for SILE to be able to output its own AST, in SIL or XML (= AST dumping and round-tripping - I might comment further later on the idea, for a glimpse of what it could be see, see this discussion and as an example of what it could be used for, see these tests. If it proves doable, that what I'd prefer actually, if efforts are to be involved in such a direction...
Sorry for that long text, but I hope I am not walking on eggshells and this proposal makes its points decently and fairly.
EDIT: BTW this would likely Close #413