Cleanup book class, set sane defaults, expand arsinal of tools #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
changed the title
BREAKING CHANGE: Any books that used this layout by default and manually fixed this by either skipping a page or reversing the left/right masters will need to undo those hacks to get their proper layout back.
BREAKING CHANGE: Any usage of \book:chapterfont{} and friends will need to
change to \book:chapter:font{} and so forth.
Besides the rename this also adds the missing book:<level>:pre hooks for
higher level headings.
BREAKING CHANGE: The :pre and :post function names didn't make any sense because they were not actually before or after the chapter (or whatever level) headings but just around the numbers. This makes it a lot more clear in say a book or project library what is actually being done. This is a step towards making the heading levels easier to style.
|
No idea if that merge resolution makes any sense, this branch was only 2748 commits behind master! I couldn't even reason about what it was doing any more the code was so old. Some bits still seem to make sense, some probably are obsolete and should be backed out. |
|
Nope merge is borked. I'll probably just look through the commits again and cherry pick instead of trying to fix the whole branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The book class is missing a few basic things I would expect (like
\partand\title(or\titlepage?) handling. It also has a few things backwards (like gutter margin on the right in what is otherwise an LTR default layout).This is a work in progress to fix those things.
[x] Flip gutter margin side, fix Book gutter on wrong side by default #598\partcommand, fix Book class could use a \part command #601