Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

标签管理 #297

Merged
merged 9 commits into from
Jul 29, 2020
Merged

标签管理 #297

merged 9 commits into from
Jul 29, 2020

Conversation

heyangfan
Copy link
Contributor

标签管理

@silenceper
Copy link
Owner

不建议为tag单独放一个包，统一user包下，建一个tag.go，作为User struct的方法

@heyangfan
Copy link
Contributor Author

ok

@heyangfan
Copy link
Contributor Author

标签下也有一个获取OPENID的列表,唯一的区别是没有total字段 是在创建一个OpenIdList类似的 比如TagOpenIDList 还是复用 user下的?

@silenceper
Copy link
Owner

嗯 跟随文档定义来

@heyangfan
Copy link
Contributor Author

改完了,还有什么建议 您提 我第一次尝试PR ,您多见谅

silenceper
silenceper reviewed Jul 7, 2020
View reviewed changes
Copy link
Owner

@silenceper silenceper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本地运行一下 golangci-lint run . 修复一些错误。

goimports -w . 可以统一下格式

@silenceper silenceper added this to the v2.0.2 milestone Jul 8, 2020
@silenceper silenceper merged commit 811d71c into silenceper:release-2.0 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silenceper silenceper silenceper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heyangfan @silenceper