Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加GetPhoneNumberContext方法 #587

Merged
merged 4 commits into from Jul 27, 2022
Merged

添加GetPhoneNumberContext方法 #587

merged 4 commits into from Jul 27, 2022

Conversation

lnnt
Copy link
Contributor

@lnnt lnnt commented Jul 25, 2022

No description provided.

Copy link
Collaborator

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silenceper
Copy link
Owner

/hold

util/http.go Outdated Show resolved Hide resolved
@@ -84,7 +84,7 @@ func (auth *Auth) CheckEncryptedDataContext(ctx context2.Context, encryptedMsgHa
if at, err = auth.GetAccessToken(); err != nil {
return
}
if response, err = util.HTTPPostContext(ctx, fmt.Sprintf(checkEncryptedDataURL, at), "encrypted_msg_hash="+encryptedMsgHash); err != nil {
if response, err = util.HTTPPostContext(ctx, fmt.Sprintf(checkEncryptedDataURL, at), []byte("encrypted_msg_hash="+encryptedMsgHash), ""); err != nil {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改为[]byte的作用主要是什么

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stepbystep2 这里说明一下

@lnnt lnnt requested a review from silenceper July 26, 2022 02:13
Copy link
Owner

@silenceper silenceper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

总体没啥问题,只是在想可能其他方法可能也有类似需求,可能需要一个统一解决方案。
这个我先merge了吧,感谢!

@silenceper silenceper merged commit 108a65e into silenceper:v2 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants