Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow function #1127

Closed
gtiani opened this issue Jun 12, 2021 · 12 comments
Closed

Slideshow function #1127

gtiani opened this issue Jun 12, 2021 · 12 comments
Labels

Comments

@gtiani
Copy link

gtiani commented Jun 12, 2021

Is there a way to make the Slideshow function respond to a finger swipe action rather then requiring a click on the arrows?
The arrow click is good when working on a PC with a mouse. But, on a small cellphone a finger swipe would be easier.

@lexoyo
Copy link
Member

lexoyo commented Jun 13, 2021

hello
the slideshow component is supposed to handle swipes on mobile, did you try and find out it doesn't work?
please provide your test online if you did
thx

@gtiani
Copy link
Author

gtiani commented Jun 13, 2021

Hi,
The slideshow is used on the first page of mistibooks.com about halfway down the page. It works by clicking the arrows but not with swipes.
Gary

@lexoyo
Copy link
Member

lexoyo commented Jun 13, 2021

ok I found this which might explain why and how to fix it

https://stackoverflow.com/questions/17545319/jquery-unslide-touch-doesnt-work

i am not sure when i will have time to fix it but i will try to do it in less than a month or 2

@lexoyo lexoyo added the bug label Jun 17, 2021
@lexoyo
Copy link
Member

lexoyo commented Jun 17, 2021

@gtiani I just released a new version of Silex, see details here
In the change logs I see "fix slideshow on mobile"
So please try again and check if it works better now (remove and add a new slideshow)

@gtiani
Copy link
Author

gtiani commented Jun 18, 2021

Hello,
No luck. I opened Silex & my website, deleted the slideshow, added a new slideshow and add 4 slides. Then re-built the website, published, and deployed. The new website is at mistibooks.com and works as before. The slideshow works fine if I click on the left and right arrows or click on the circles along the bottom of the slideshow. However, a finger swipe action does not move the slides. I tested the site on my cellphone. Other websites that I visit work fine with a swipe action. The Silex built website does not respond to a swipe action. If there is anything else that I could try, please let me know.
Sincerely,
Gary

@lexoyo lexoyo closed this as completed in f9f4a46 Jul 11, 2021
lexoyo added a commit that referenced this issue Jul 11, 2021
@lexoyo
Copy link
Member

lexoyo commented Jul 11, 2021

hello @gtiani
I think I managed to fix this issue with #1136
It is live on https://preprod.silex.me/
Could you give it a go and let me know if it is fixed? You need to delete all slideshows first then add them again

@gtiani
Copy link
Author

gtiani commented Jul 12, 2021

Hello Alex,
I tried opening my editable website using preprod.silex.me. However, the two pages of my website are all displayed on a single page with both pages mixed. When I try to add a slideshow, the location defaults to the bottom of the page rather than where I am trying to place it. Should the version in preprod.silex.me be backward compatible and display my website the same as the previous version?

@lexoyo
Copy link
Member

lexoyo commented Jul 31, 2021

@gtiani could you try again on preprod please?
Also if it does not work please share your site with me

@lexoyo lexoyo reopened this Jul 31, 2021
@gtiani
Copy link
Author

gtiani commented Aug 1, 2021

Hello Alex,
No luck. My website won't open correctly. You can see the problem by opening the "clean-square" example. When I open it with the Silex.me site, everything works fine and I can toggle between the two pages. However, if I use the preprod.silex.me and open "clean-square", everything is on a single page and I cannot toggle between the two pages.
Am I doing something wrong? Should the preprod.silex.me be able to open the "clean-square" example?
Sincerely,
Gary

@lexoyo
Copy link
Member

lexoyo commented Aug 1, 2021

Oh ok
Thank you for the example, I will fix this

@lexoyo
Copy link
Member

lexoyo commented Aug 15, 2021

@gtiani preprod.silex.me is fixed, sorry about that, some files where missing

Please try again the swipe

@gtiani
Copy link
Author

gtiani commented Aug 17, 2021

Eureka!!!! It works.
It's so much easier to use the swipe motion rather than trying to click on the small arrow.
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants