Heroku one-click deploy fails

[pseudozach]

In the section How to Host An Instance of Silex
"For the lazy ones, there is the Heroku One-Click Deploy:" button fails because Heroku complains there are no app.json under https://github.com/silexlabs/Silex/tree/master.

[lexoyo]

Hello
Thank you for the report
Is it possible for you to add the app.json and submit a pull request?

[swakarm]

Here is an example of 'app.json'
https://devcenter.heroku.com/articles/app-json-schema#example-app-json

[lexoyo]

Hi @swakarm
Would like me to guide you to add it yourself to Silex code?

[swakarm]

I have submitted a pull request.
for app.json

[lexoyo]

It works great !

There is still something to do for it to be perfect: as stated in Silex wiki here, we need to define some environment variables for Silex to work properly. I think it is possible to tell heroku to ask for the values when a user deploys Silex

[lexoyo]

Also the build on heroku fails: java: not found
We need to add the java "toolbelt" if I remembeer correctly
@swakarm could you look into it?
The link to try it out is https://heroku.com/deploy?template=https://github.com/silexlabs/Silex/tree/develop

[swakarm]

I am still getting an error ,'No app.json located in the repo URL provided.'
Make sure that repo URL is true or not.

[swakarm]

I am new to Silex . So I am observing your source code. My schedule is also too busy. So I will try to solve problems whenever I will be free. So do not expect from me for more support. I am sorry for that. Thanks for making Silex builder opensource. Science is depended on selfless people like You, Who works without expecting profit.

[lexoyo]

I am still getting an error ,'No app.json located in the repo URL provided.' Make sure that repo URL is true or not.

Did you use this URL?
It is the one for develop branch
https://heroku.com/deploy?template=https://github.com/silexlabs/Silex/tree/develop

[swakarm]

oh, I clicked button for one click deploy. Now I have tried 'develop' branch. It works.

[swakarm]

Observing package.json

"Java not found" error is because of heroku could not find files in directory, which are described in script- 'build:js:release' and 'build:js:debug'

Also check at "dependency"
"google-closure-compiler": "20170218.0.0",
"google-closure-library": "20170218.0.1",

I think there is a problem with Google closure complier at heroku.
We have two options to solve this problem.

1.- Remove dependency of Google closure copmiler from source code of silex. (for heroku)
OR
2.- Compiling code with java script version of Google closure compiler which does not require JAVA
https://github.com/google/closure-compiler-js

[lexoyo]

It is possible to add Java to heroku I don't know how but I know it is what we need Le 7 sept. 2018 à 13:54, à 13:54, Jayesh Sindhav <notifications@github.com> a écrit:

…

**Observing package.json** "Java not found" error is because of heroku could not find files in directory, which are described in script- 'build:js:release' and 'build:js:debug' Also check at "dependency" "google-closure-compiler": "20170218.0.0", "google-closure-library": "20170218.0.1", I think there is a problem with Google closure complier at heroku. We have two options to solve this problem. 1.- Remove dependency of Google closure copmiler from source code of silex. (for heroku) OR 2.- Compiling code with java script version of Google closure compiler which does not require JAVA https://github.com/google/closure-compiler-js -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #741 (comment)

[lexoyo]

Hi
@pseudozach and @swakarm
I have added the env vars and buildpacks to app.json, it should work properly now
8d62548
Let me know if you find any bug
Thank you for your contributions!