Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shortcuts #1599

Merged
merged 8 commits into from
May 29, 2024
Merged

New shortcuts #1599

merged 8 commits into from
May 29, 2024

Conversation

SuperDelphi
Copy link
Contributor

This pull request brings the following shortcuts:

  • R to open the Style Manager ;
  • T to open the Traits Manager ;
  • Ctrl+D to duplicate one or multiple components ;
  • Ctrl+Alt+P to publish the website.

It also fixes a bug in the Publish dialog where it would cause an error when closed if it hadn't been opened with the usual button.

Copy link
Contributor Author

@SuperDelphi SuperDelphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comments to justify some choices!

@SuperDelphi
Copy link
Contributor Author

Yes, I'm talking about GitHub comments, sorry.

package.json Outdated Show resolved Hide resolved
src/ts/client/grapesjs/keymaps.ts Outdated Show resolved Hide resolved
src/ts/client/grapesjs/keymaps.ts Outdated Show resolved Hide resolved
src/ts/plugins/server/GitlabHostingConnector.ts Outdated Show resolved Hide resolved
@lexoyo
Copy link
Member

lexoyo commented May 27, 2024

Also if it is simple could you update the title on the "open traits" and "open properties" buttons with the shortcut
Screenshot from 2024-05-27 17-05-42

Copy link
Contributor Author

@SuperDelphi SuperDelphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexoyo The bugs are fixed! I've also greatly simplified the keymaps.ts file.

@SuperDelphi SuperDelphi requested a review from lexoyo May 28, 2024 14:47
@lexoyo
Copy link
Member

lexoyo commented May 29, 2024

Also if it is simple could you update the title on the "open traits" and "open properties" buttons with the shortcut Screenshot from 2024-05-27 17-05-42

what about this comment?

package.json Outdated Show resolved Hide resolved
@lexoyo lexoyo merged commit 4a6b6c0 into silexlabs:dev May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants