GitLab policy error fix #1605
Merged
GitLab policy error fix #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verify their GitLab account when needed + Loading bar visual improvement
lexoyo
requested changes
Jun 19, 2024
* gitlab hosting connector with good current job id return * gitlab hosting connector with good current job id return 2 * gitlab hosting connector with good current job id return v3 * with setTimout problem corrected * with setTimout problem corrected 2 * with setTimout problem corrected 3 * with setTimout problem corrected 3 * with setTimout problem corrected 3 * with setTimout problem corrected 4 * with setTimout problem corrected 4 * with setTimout problem corrected 5 * with setTimout problem corrected 5 * with setTimout problem corrected 6 * with timer in variables --------- Co-authored-by: Ubuntu <ubuntu@ov-bddc60.infomaniak.ch>
…verify their GitLab account when needed + Loading bar visual improvement
SuperDelphi
commented
Jun 19, 2024
lexoyo
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the GitLab hosting connector to handle a case where the publication fails because the GitLab user is recent. The connector will check if it's plugged to the official GitLab instance, and if so, it will display a clear message inside the publication dialog, with a clickable link.
On a side note, the loading bar ( element) inside the publication dialog has been slightly improved.