This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
made it easier to replace the translator service with an implementation of TranslatorInterface #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of TranslatorInterface
| @@ -72,7 +72,7 @@ public function register(Container $app) | |||
| if (isset($app['validator'])) { | |||
| $extensions[] = new FormValidatorExtension($app['validator']); | |||
|
|
|||
| if (isset($app['translator'])) { | |||
| if (isset($app['translator']) && method_exists($app['translator'], 'addResource')) { | |||
There was a problem hiding this comment.
why not $app instanceof TranslatorInterface?
There was a problem hiding this comment.
$app is never a translator. It is the Silex application
And addResource is not part of the TranslatorInterface, which is precisely the reason for this check
|
👍 |
fabpot
added a commit
that referenced
this pull request
Jun 30, 2014
… implementation of TranslatorInterface (fabpot) This PR was merged into the 2.0.x-dev branch. Discussion ---------- made it easier to replace the translator service with an implementation of TranslatorInterface fixes #961 Commits ------- d7500db made it easier to replace the translator service with an implementation of TranslatorInterface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #961