Add support for settings (picking root folders) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 4 alerts when merging a8535d5 into 5c6391a - view on LGTM.com new alerts:
|
grahammcculloch
force-pushed
the
basic-settings
branch
from
a8535d5
to
cbd0426
Compare
|
This pull request introduces 4 alerts when merging cbd0426 into 5c6391a - view on LGTM.com new alerts:
|
This was referenced Jul 18, 2020
There was a problem hiding this comment.
Nice refactor; looks good. A couple of wider issues:
- we should consider migrating AppState data from the old store if it exists to have a consistent UX Migrate AppState data from the old store #76
- would be good to have a reset-to-default for directories settings Add reset to default directory in the Settings drawer #75
irahopkinson
force-pushed
the
basic-settings
branch
from
cbd0426
to
29ce8e6
Compare
|
This pull request introduces 4 alerts when merging 29ce8e6 into bca7d15 - view on LGTM.com new alerts:
|
irahopkinson
force-pushed
the
basic-settings
branch
from
29ce8e6
to
c6a4097
Compare
|
This pull request introduces 4 alerts when merging c6a4097 into 845898e - view on LGTM.com new alerts:
|
This is cleaner than manually persisting to local storage.
Commit body Change-type: patch|minor|major Signed-off-by: Graham McCulloch <graham@balena.io>
Commit body Change-type: patch|minor|major Signed-off-by: Graham McCulloch <graham@balena.io>
Note: The implementation in sources/scripture-app-builder.js is still required before any Scripture App Builder projects will be returned. At the moment we just return an empty array!
Refactor mobx store to contain two store classes, appState and settings.
* Updating settings will trigger a projects refresh. * Settings button is disabled while processing.
irahopkinson
force-pushed
the
basic-settings
branch
from
c6a4097
to
c3ad73a
Compare
|
This pull request introduces 4 alerts when merging c3ad73a into 845898e - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for Settings - current just allows the user to specify the HearThis and Scripture App Builder root directories.
(This is branched off the
scripture-app-builder-uibranch so that should be completed and merged before we merge this one).