Change package push to use nuget CLI instead of dotnet

[jasonleenaylor]

This change is 

[marksvc]

---

.github/workflows/fw_icu4c_ci.yml, line 101 at r1 (raw file):

      if: github.event_name == 'push'
      working-directory: icu4c
      run: nuget push -ApiKey **/*.nupkg ${{ secrets.ICU_NUGET_API_KEY }}

I would have thought the ${{ secrets.ICU_NUGET_API_KEY }} would come immediately after -ApiKey. But maybe not.

Also, there is a possibility that there are other foo.nupkg files in the tree. Perhaps ones downloaded as external dependencies. If not, then **/*.nupkg may be fine. But if so, then you may be including and pushing more than you intended.

Code quote:

 -ApiKey **/*.nupkg ${{ secrets.ICU_NUGET_API_KEY }}

[jasonleenaylor]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @marksvc)

---

.github/workflows/fw_icu4c_ci.yml, line 101 at r1 (raw file):

Previously, marksvc wrote…

I would have thought the ${{ secrets.ICU_NUGET_API_KEY }} would come immediately after -ApiKey. But maybe not.

Also, there is a possibility that there are other foo.nupkg files in the tree. Perhaps ones downloaded as external dependencies. If not, then **/*.nupkg may be fine. But if so, then you may be including and pushing more than you intended.

And this is why we have code review. Also it is what comes from me trying to rush changes in between meetings.

[papeh]

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)