handful of small Ansible fixes #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated as of Ansible 2.2. Output: ``` TASK [silpion.tomcat : Register static/unmanaged conf files] ******************* [DEPRECATION WARNING]: always_run is deprecated. Use check_mode = no instead.. This feature will be removed in version 2.4. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg. ```
From [the `template` docs](http://docs.ansible.com/ansible/template_module.html#options): > Leaving off the leading zero will likely have unexpected results. which I confirmed: ``` $ ls -l /etc/systemd/system/tomcat@.service --w----r-T. 1 root root 1678 Jan 24 23:17 /etc/systemd/system/tomcat@.service ```
|
Looks good to me. I was just about to submit a PR for similar changes to resolve the deprecation warnings. Merged the changes from @afeld into my copy of the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits. Let me know if you'd like me to break them up into individual pull requests. Thanks!