Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handful of small Ansible fixes #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

handful of small Ansible fixes #26

wants to merge 3 commits into from

Commits on Jan 25, 2017

  1. clarify the expected format for the version variables

    @afeld
    afeld committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    7070fd7 View commit details
    Browse the repository at this point in the history

  2. use check_mode instead of always_run 

    Deprecated as of Ansible 2.2. Output:

```
TASK [silpion.tomcat : Register static/unmanaged conf files]
*******************
[DEPRECATION WARNING]: always_run is deprecated. Use check_mode = no
instead..
This feature will be
 removed in version 2.4. Deprecation warnings can be disabled by setting
deprecation_warnings=False
 in ansible.cfg.
```
    @afeld
    afeld committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    00ddea4 View commit details
    Browse the repository at this point in the history

  3. fix file modes for service files 

    From [the `template`
docs](http://docs.ansible.com/ansible/template_module.html#options):

> Leaving off the leading zero will likely have unexpected results.

which I confirmed:

```
$ ls -l /etc/systemd/system/tomcat@.service
--w----r-T. 1 root root 1678 Jan 24 23:17
/etc/systemd/system/tomcat@.service
```
    @afeld
    afeld committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    ddad4aa View commit details
    Browse the repository at this point in the history