Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo & obsolete keys in users endpoint API documentation #629

Closed
jeromecc opened this issue Jan 31, 2019 · 1 comment
Closed

typo & obsolete keys in users endpoint API documentation #629

jeromecc opened this issue Jan 31, 2019 · 1 comment

Comments

@jeromecc
Copy link
Contributor

Hi!

/silver/docs/billing-entities/customers.md

"<b>name</b>": "John Doe",
"company": "ACME Inc.",
"email": "johndoe@acme.inc",
"<b>address_1</b>": "Funny Road no.4",
"address_2": null,
"country": "US",
"<b>city</b>": "Wilmington",

Typos: bold html tags in key names

Obsolete key: "name" which was divided into "first_name" & "last_name"

Thanks for sharing the code of this great app!

jérôme
jeromecc added a commit to DocTocToc/silver that referenced this issue Jan 31, 2019
@jeromecc
fix typo & obsolete keys in users endpoint API documentation silverap…
b922ec0 
…p#629
jeromecc added a commit to DocTocToc/silver that referenced this issue Jan 31, 2019
@jeromecc
fix typo & obsolete keys in users endpoint API documentation silverap…
5bf5a29 
…p#629
bogdanpetrea pushed a commit that referenced this issue Jan 31, 2019
@jeromecc @bogdanpetrea
fix typo & obsolete keys in users endpoint API documentation #629
d9c2fab
@bogdanpetrea
Copy link
Contributor

Thanks @jeromecc, I've merged your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeromecc @bogdanpetrea