Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Registration form improvements #33

Closed
wants to merge 6 commits into from
Closed

Registration form improvements #33

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2016

  • Changed userForm to registerForm for consistency
  • Added email validation using ng-pattern and regex
  • Added password_confirmation field
  • Checking if password and password_confirmation are the same
  • Centered "I already have an account"
  • Added some rows / cols @ register page
  • Changed form "title" to an h3 to stay in line with the other forms like forgot password
  • Updated password_confirmation input. Added password-verify directive
  • Updated test to reflect the new field
  • Added validation rule for password_confirmation field (AuthController#190)

@silverbux
Copy link
Owner

Hi, first thank you for the awesome PR's

Just some minor adjustments.

@ghost
Copy link
Author

ghost commented Jun 7, 2016

@silverbux about indentation. Do you have some guidelines ? Like spaces before tabs, how many spaces and so on.

Because if I reformat the whole file I change pretty much everything.

@silverbux
Copy link
Owner

silverbux commented Jun 7, 2016

currently on HTML Files i still haven't set any standards or guidelines yet except for the typical code structuring, probably 2 space as indention will do for now.

@silverbux
Copy link
Owner

Was conflicting and had to merge manually reference: 9f63fec

@silverbux silverbux closed this Jun 8, 2016
@ghost ghost deleted the registration-form-component-improvements branch June 8, 2016 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant