feat: allow for additional params on conditionalPut #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthomerson
force-pushed
the
jrthomer/filter-getobject-params
branch
from
e6140fa
to
5ea69e4
Compare
When you add params like `ContentType` to your conditionalPut, those were being sent to the GetObject call as well. Now we filter the params sent to the GetObject call so that no unsupported params are sent to it.
jthomerson
force-pushed
the
jrthomer/filter-getobject-params
branch
from
5ea69e4
to
ddaf4af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add params like
ContentTypeto your conditionalPut, thosewere being sent to the GetObject call as well. Now we filter the params
sent to the GetObject call so that no unsupported params are sent to it.