Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email templates should be taken from defined frontend theme(s) #793

Closed
wernerkrauss opened this issue Oct 18, 2023 · 1 comment
Closed

Email templates should be taken from defined frontend theme(s) #793

wernerkrauss opened this issue Oct 18, 2023 · 1 comment

Comments

@wernerkrauss
Copy link
Contributor

With cascading themes it's easy to set up different shops with one code base and several sub themes for each installation.

When putting email templates in /themes/, they're not recognised when emails are sent from the backend, e.g. Order_StatusEmail.ss

IMHO sending emails should switch to the defined frontend theme, send the email and switch back for each email.

When email templates are in app/templates, this should still overrule themes' templates.
wernerkrauss added a commit to wernerkrauss/silvershop-core that referenced this issue Oct 18, 2023
@wernerkrauss
emails should use configured themes
629a827 
fixes silvershop#793
@wernerkrauss wernerkrauss mentioned this issue Oct 27, 2023
Merged
wernerkrauss added a commit that referenced this issue Oct 27, 2023
@wernerkrauss
Merge pull request #799 from wernerkrauss/fix-793-794
6be2a2b 
Improve email generation and testing

fixes #793
fixes #794
@wernerkrauss
Copy link
Contributor Author

fixed by #799

wernerkrauss added a commit that referenced this issue Feb 20, 2024
@wernerkrauss
emails should use configured themes
168bb8e 
fixes #793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wernerkrauss