Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny improvements to timezone module: make list protected #3

Open
chillu opened this issue Mar 20, 2013 · 0 comments
Open

tiny improvements to timezone module: make list protected #3

chillu opened this issue Mar 20, 2013 · 0 comments

Comments

@chillu
Copy link
Member

chillu commented Mar 20, 2013

Moved from http://open.silverstripe.org/ticket/5109, cc @sunnysideup

I just had a look at:

http://open.silverstripe.org/browser/modules/timezoneawareness/trunk/code/TimezoneField.php

I am wondering if we should have lists like timezones (and also countries and other generic lists) in a special folder in sapphire rather than invididual files. That makes it more likely that several classes can and will use the same list.

Also, here are some specific recommendations for http://open.silverstripe.org/browser/modules/timezoneawareness/trunk/code/TimezoneField.php

$timezone_list should be a static protected variable rather than a public one, using a get and set function for write/read access.

In the description, "over" should be "cover".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant