Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Github source code #59

Closed
chillu opened this issue Nov 26, 2017 · 7 comments · Fixed by #94
Closed

Link to Github source code #59

chillu opened this issue Nov 26, 2017 · 7 comments · Fixed by #94

Comments

@chillu
Copy link
Member

chillu commented Nov 26, 2017

The old API generator inlined the PHP code - and it looks like many people miss that (see silverstripe/silverstripe-framework#7625).

@williamdes
Copy link
Contributor

/close ?

@ntd
Copy link

ntd commented Dec 16, 2020

I am one of the people missing the good ol' link. I just checked the online documentation and the issue is still present.

@williamdes
Copy link
Contributor

williamdes commented Dec 16, 2020

Do you mean the at line x on https://laravel.com/api/5.8/Illuminate/Auth/Events/Authenticated.html ?

Can you explain more ?
Or open an issue at https://github.com/code-lts/doctum ?

@ntd
Copy link

ntd commented Dec 16, 2020

Do you mean the at line x on https://laravel.com/api/5.8/Illuminate/Auth/Events/Authenticated.html ?

No, the links work fine for laravel: I meant the online SilverStripe API. There the at line ... references are just plain text, see e.g.
https://api.silverstripe.org/4/SilverStripe/Admin/ModelAdmin.html

Maybe it just needs to be updated.

@williamdes
Copy link
Contributor

Oh yeah it only needs the https://github.com/code-lts/doctum#configuration
'remote_repository' => new GitHubRemoteRepository('username/repository', '/path/to/repository'),

I had to use an external repository for the example ;p

@chillu
Copy link
Member Author

chillu commented Dec 17, 2020

@williamdes We already have remote_repository in the project section of the config, but it doesn't apply? https://github.com/silverstripe/api.silverstripe.org/blob/master/conf/doctum.php#L82

I'm a bit unclear on how we can set this separately for each package, the API docs are a composite of multiple repos (silverstripe/framework, silverstripe/cms etc)

@williamdes
Copy link
Contributor

Looks like it doesn't work on your side
I will have a look ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants