Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Require admin ^1.10 #104

Merged
merged 1 commit into from
Nov 18, 2021
Merged

DEP Require admin ^1.10 #104

merged 1 commit into from
Nov 18, 2021

Conversation

emteknetnz
Copy link
Member

This was referenced Nov 17, 2021
Closed
Merged
@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 17, 2021 •
edited
Loading

This PR won't be installable on travis due to COMPOSER_ROOT_VERSION not being correct - https://app.travis-ci.com/github/silverstripe/cwp-core/jobs/548440953#L391 and attempting to install cwp-recipe-cms

Given the nature of this change - I think it's safe to merge without the travis check

maxime-rainville
maxime-rainville approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I would say create the matching branch on the other end so the thing is installable, but that would probably mean creating a bunch of other branches from there. So we wight as well just do the beta and creating all the branches there.

@maxime-rainville maxime-rainville merged commit a15af42 into 2.9 Nov 18, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/admin110 branch November 18, 2021 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emteknetnz @maxime-rainville