Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Use carets instead of dev requirements and use phpunit 9 #3

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

emteknetnz
Copy link
Member

Issue https://github.com/silverstripeltd/product-issues/issues/497

Now that CWP won't be getting regular releases via cow, it probably makes sense to change this to carets to support adhoc releases

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@emteknetnz
Copy link
Member Author

^ broken travis test is phpunit9 related - fix is to tag 2.9.0 (new minor) of cwp-core - https://github.com/silverstripe/cwp-core/pull/101/files

@maxime-rainville this might be a bit weird, particularly as that requires framework ^4.10 which is unreleased - may make sense to just merge this with broken unit test?

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Nov 11, 2021

@emteknetnz Do you want to do a new cwp-core tag. It seemed to work for the other module?

@emteknetnz
Copy link
Member Author

@maxime-rainville tagged cwp-core 2.9.0 and rerunning the build on this

@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 14, 2021

Unit test requires silverstripe/admin 4.10/4.x-dev due to phpunit 9

Requirement for admin would need to be updated in to ^4.10 in
https://github.com/silverstripe/cwp-core/blob/2/composer.json

However I tagged cwp-core 2.9.0 just the other day, probably a little excessive tagged 2.10 days later - might make sense to just remove the tag and retag - though this would require us deleting the tag in packagist as well which I don't have enough permissions to do https://packagist.org/packages/cwp/cwp-core#2.9.0

Other option is just tag 2.9.1, though I'm not sure if that's semver correct

@maxime-rainville
Copy link
Contributor

I'm fine tagging 2.9.1. As a general rule, we should never undo a tag.

@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 15, 2021

Cool - PR silverstripe/cwp-core#104

Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and build are green.

@maxime-rainville maxime-rainville merged commit 91d2a3c into silverstripe:2 Nov 23, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/carets branch November 23, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants