MNT Handle DatabaseExceptions thrown by PHP 8.1 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2.9/broken-builds
branch
from
f5220e7
to
24c4d72
Compare
|
I don't think this actually solves the problem - users are going to get different behaviour depending on what database version is used which is not good. |
emteknetnz
force-pushed
the
pulls/2.9/broken-builds
branch
11 times, most recently
from
dddcdd6
to
248faa7
Compare
|
Changed solution, this matches behavior to PHP < 8.1 |
GuySartorelli
requested changes
Jul 18, 2022
src/PageTypes/DatedUpdateHolder.php
Outdated
| strpos($e->getMessage(), 'Incorrect DATETIME value') !== false | ||
| ) { | ||
| $controller->getRequest()->getSession()->set(DatedUpdateHolderController::TEMP_FORM_MESSAGE, _t( | ||
| __CLASS__ . '.InvalidDateFormat', |
There was a problem hiding this comment.
Suggested change
| __CLASS__ . '.InvalidDateFormat', | |
| DatedUpdateHolderController::class . '.InvalidDateFormat', |
emteknetnz
force-pushed
the
pulls/2.9/broken-builds
branch
from
248faa7
to
d14cf42
Compare
GuySartorelli
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 set the MySQLi default error mode to exceptions https://php.watch/versions/8.1/mysqli-error-mode
This resulted in https://github.com/silverstripe/cwp/runs/7351123074?check_suite_focus=true
It would have been nice to just add
| DatabaseExceptiontocwp/src/PageTypes/DatedUpdateHolderController.php
Line 178 in 192a902
However the failing FunctionalTest (which makes an HTTP request to the frontend) simply doesn't go through this bit of code.