Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: DRY update for managing documented module checkouts. (Fixes #2) #5

Merged
merged 5 commits into from Sep 9, 2012
Merged

Conversation

wilr
Copy link
Member

@wilr wilr commented Sep 9, 2012

Moved logic from makefile to bin/update.sh.

@sminnee
Copy link
Member

sminnee commented Sep 9, 2012

I think there should be an action for doing both "make update" and "make index" in a single step. "make maintenance" or "make periodic"? The point is that the pair of actions need to be attached to the scheduled task and the deployer shouldn't need to specify the individual maintenance tasks.

It'd also be good to update the readme with instructions about how to configure the cronjob on the host.

@wilr
Copy link
Member Author

wilr commented Sep 9, 2012

Well to avoid breaking it when you deploy, I'll keep make update to do both, add a 'fetch' for getting the documentation. Noticed a issue with the 3.0 and building the index via sake so will submit amendments for that now.

@sminnee
Copy link
Member

sminnee commented Sep 9, 2012

Sounds good. Just trying to make the information about this system self-contained. ;-)

sminnee added a commit that referenced this pull request Sep 9, 2012
FIX: DRY update for managing documented module checkouts. (Fixes #2)
@sminnee sminnee merged commit d50e586 into silverstripe:master Sep 9, 2012
GuySartorelli pushed a commit to creative-commoners/doc.silverstripe.org that referenced this pull request Jan 30, 2024
Added documentation for setting up advancedworkflow simple review and approve process.
GuySartorelli pushed a commit to creative-commoners/doc.silverstripe.org that referenced this pull request Jan 30, 2024
BUGFIX send correct mimie types for attached files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants