FIX Handle zero-match #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
GuySartorelli
requested changes
Jul 3, 2022
There was a problem hiding this comment.
Looks good. : is effectively an alias for true so not super readable but the comment makes up for that.
Have tested and confirmed that if any of the greps in this command exit 1, and therefore we use : as the output of that segment instead, the whole command will exit 0 with no output. So no worries with this as a way to stop exiting 1.
emteknetnz
force-pushed
the
pulls/1.1/zero-match
branch
from
7763204
to
b9931fa
Compare
GuySartorelli
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11
If grep has zero results, it results in an exit code of 1 which halts the workflow