ENH Set logger to "debug" so deprecations show #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Actually, on second thought I don't want this - it's easy enough to turn this on custom branches on silverstripe/installer via yml - we already get all the error output we need in consoles, and this logging is only relevant for deprecation work, which will be done shortly anyway. |
|
Reopening - we need for behat |
emteknetnz
force-pushed
the
pulls/1.2/log-info
branch
from
3023079
to
2914063
Compare
emteknetnz
changed the title
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/1.2/log-info
branch
from
2914063
to
45a1836
Compare
sabina-talipova
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10542
Other issue #53
I don't think there's any real downside since the silverstripe.log file never seems to show in the artifacts anyway even on red builds. There's more disk space used for artifacts, though I'd imagine that we're still far below whatever the quota is.