FIX Only use git diff #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
approved these changes
Jul 19, 2022
dhensby
reviewed
Jul 20, 2022
| echo "git diff files:" | ||
| echo $GIT_DIFF_FILES | ||
| fi | ||
| git add . |
There was a problem hiding this comment.
Why run the git add command? git diff will reveal changes that are not staged, git diff --cached will show diffs for those that are...
but if you're running both git diff and git diff --cached then what's the need to stage any changes?
There was a problem hiding this comment.
In case there were any dist files that for whatever reason were previously deleted and committed. When rebuilding the dist files we need to git add them for them to show, otherwise they're untracked.
Probably don't need both git diff and git diff --cached though, but it's harmless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/gha-ci#37