Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Ensure client directory exists before running git diff #9

Merged
merged 1 commit into from
Jul 25, 2022
Merged

FIX Ensure client directory exists before running git diff #9

merged 1 commit into from
Jul 25, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 25, 2022 •
edited
Loading

Issue silverstripe/gha-ci#37

Fix https://github.com/silverstripe/cwp-starter-theme/runs/7487562275?check_suite_focus=true
Running git diff fatal: pathspec 'client' did not match any files

@emteknetnz emteknetnz mentioned this pull request Jul 25, 2022
Closed
GuySartorelli
GuySartorelli requested changes Jul 25, 2022
View reviewed changes
action.yml Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah good point, it's dist we care about in that case, not src.
Looks good.

@GuySartorelli GuySartorelli merged commit 008fcd7 into silverstripe:1.0 Jul 25, 2022
@GuySartorelli GuySartorelli deleted the pulls/1.0/no-client-dir branch July 25, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli