FIX Ensure injectable version of queuedjobs is installed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2.10/gha
branch
from
d8da8bc
to
d4bf6cb
Compare
|
Still failing on testBatching and christmas date. |
GuySartorelli
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/gha-ci#37
Fix prefer-lowest
https://github.com/silverstripe/recipe-solr-search/runs/7440645243?check_suite_focus=true
ERROR [Emergency]: Uncaught Error: Call to undefined method Symbiote\QueuedJobs\Services\QueuedJobService::singleton()https://github.com/silverstripe/recipe-solr-search/runs/7440645243?check_suite_focus=true#step:10:859
^ required queuedjobs 4.9 rather than 4.1 due to the requirement for PHPUnit9 compatibility
https://github.com/silverstripe/recipe-solr-search/runs/7441484862?check_suite_focus=true#step:12:55
Fatal error: Declaration of Symbiote\QueuedJobs\Tests\AbstractTest::setUp() must be compatible with SilverStripe\Dev\SapphireTest::setUp(): void in /home/runner/work/recipe-solr-search/recipe-solr-search/vendor/symbiote/silverstripe-queuedjobs/tests/AbstractTest.php on line 17Fix
Incorrect DATETIME value: 'christmas 00:00:00'https://github.com/silverstripe/recipe-solr-search/runs/7440645405?check_suite_focus=true#step:12:88
Maybe fix
1) SilverStripe\FullTextSearch\Tests\BatchedProcessorTest::testBatching Failed asserting that 15 matches expected 9.https://github.com/silverstripe/recipe-solr-search/runs/7440645300?check_suite_focus=true#step:12:69