BUG Fixed issue with cms help toggles not functioning correctly #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -841,16 +841,26 @@ jQuery.noConflict(); | |||
| * in the href attribute (which doubles as an anchor link to that element). | |||
| */ | |||
| $('.cms .cms-help-toggle').entwine({ | |||
| ToggleElement: null, | |||
There was a problem hiding this comment.
Can we make getToggleElement() use attr() each time, rather than caching it? I'm not sure on how this affects memory leaks in jQuery.entwine, but generally try to avoid setting DOMElement as instance state anywhere. Presumably the issue was that the "href" attr had the base path prepended before the anchor link?
There was a problem hiding this comment.
Ya it was, I can have it pull the object each time the user clicks. Which your right probably would be much easier on memory.
chillu
added a commit
that referenced
this pull request
Mar 20, 2013
BUG Fixed issue with cms help toggles not functioning correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue with the custom date and custom time formatting not toggling or always displaying in SecurityAdmin.