FIX TinyMCE bug adding a link after removing a link

silverstripe · Aug 2, 2020 · 6c876f2 · 6c876f2
1 parent 055cf6d
commit 6c876f2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/client/dist/js/TinyMCE_sslink.js b/client/dist/js/TinyMCE_sslink.js
diff --git a/client/src/legacy/TinyMCE_sslink.js b/client/src/legacy/TinyMCE_sslink.js
@@ -55,10 +55,25 @@ const plugin = {
     editor.on('preinit', () => {
       setupTinyMceInlineToolbar(editor, [
         { type: 'button', onClick: openLinkDialog, text: 'Edit link' },
-        { type: 'button', onClick: () => editor.execCommand('unlink'), text: 'Remove link' },
+        { type: 'button', onClick: () => this.handleRemoveLinkClick(editor), text: 'Remove link' },
       ], ['a[href]']);
     });
   },
+
+  /**
+   * @param {Object} editor
+   */
+  handleRemoveLinkClick(editor) {
+    const result = editor.execCommand('unlink');
+    // Merge adjacent textNodes after removing <a> nodes so that tinymce.js can properly
+    // calculate a value for 'isCollapsed'
+    const node = editor.selection.getNode();
+    // IE11 normalize() compatibility is unknown
+    if (node && (typeof node.normalize !== 'undefined')) {
+      node.normalize();
+    }
+    return result;
+  }
 };
 
 jQuery.entwine('ss', ($) => {