CMS preview doesn't work inside ItemEditForm

[GuySartorelli]

silverstripe/silverstripe-framework includes a separate form in GridFieldDetailForm_ItemRequest's ItemEditForm which LeftAndMain doesn't add the necessary components to form CMS previews (cms-previewable ExtraClass and SilverStripeNavigator field).

I think an extension class should be included as a part of this module which takes advantage of the updateItemEditForm extension point of GridFieldDetailForm_ItemRequest to add these.

Edit: The following pull requests all ultimately relate to this:

• API Add a way to check if a form or field has an extra css class. silverstripe-framework#10112
• NEW: Allow CMS preview for items in GridFieldDetailForms. #1250
• ENH: Allow use of the preview panel in any LeftAndMain subclass. #1252
• NEW Add preview state for non-versioned DataObjects. silverstripe-cms#2692
• NEW Allow unversioned preview state. #1258
• DOC Document how to enable the preview panel for custom DataObjects. silverstripe-framework#10124
• FIX Right-align preview on the first record #1285
• DOC Document the unversioned preview state silverstripe-userhelp-content#171

And, as an extension of all of this:

• FIX: Get CMS preview working for non inline-editable elements. silverstripe-elemental#936

[GuySartorelli]

Oops, looks like this should have been raised in silverstripe/silverstripe-admin, since that's where the LeftAndMain cms preview code lives. Is there a clean way to move an issue?

[michalkleiner]

@GuySartorelli moved the issue from the CMS repo.

You can relink it in your PR description if you want since it changed its URL/reference now (if it didn't auto-update, looks like it might have).

[GuySartorelli]

Thanks!

[GuySartorelli]

I've put a list of pull requests that relate to this work in the original message.
I'm also working on a PR to update the docs in silverstripe/silverstripe-framework. (Edit: docs PR now linked in original message)

[maxime-rainville]

@brynwhyman Let's maybe bring this in sprint.

[GuySartorelli]

I've just found https://userhelp.silverstripe.org/en/4/creating_pages_and_content/creating_and_editing_content/previewing_changes/ which will also probably need to be updated - if only to mention that the draft/published toggle may not be available for some content.

[GuySartorelli]

@brynwhyman Let's maybe bring this in sprint.

@maxime-rainville Let me know if there's anything you need from me in that regard.
For now I think I've done all I can until there's some feedback on the PRs.

[GuySartorelli]

@emteknetnz It might be worth keeping this ticket open while the other PRs mentioned in the description are still pending - especially docs.

[emteknetnz]

Sorry yes intend to keep open, GitHub auto-closed it due to closing a linked PR

[emteknetnz]

All PRs have been merged.

Thank you once again @GuySartorelli this was a significant contribution

[GuySartorelli]

Thanks for working with me to get it in!