API Add a way to check if a form or field has an extra css class. #10112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
added a commit
to signify-nz/silverstripe-admin
that referenced
this pull request
Oct 6, 2021
For some reason, the preview panel template which is referred to in LeftAndMain::PreviewPanel() only exists in the cms module for the CMSMain controller. All of the other code for using a CMS preview is available for any arbitrary LeftAndMain subclass and is available in this module. There should be no dependency from this module on the cms module to allow previews, and previews should work for all LeftAndMain subclasses in this module (e.g. ModelAdmin). Relies on silverstripe/silverstripe-framework#10112
|
Thanks @GuySartorelli. Would you mind updating the tests to test the newly added method in both classes as well, please? |
GuySartorelli
force-pushed
the
enh/check-if-form-has-extraclass
branch
from
871d6cd
to
758e4ee
Compare
|
@michalkleiner Done! :) |
GuySartorelli
force-pushed
the
enh/check-if-form-has-extraclass
branch
from
758e4ee
to
c5003bb
Compare
GuySartorelli
force-pushed
the
enh/check-if-form-has-extraclass
branch
from
c5003bb
to
0495fa5
Compare
michalkleiner
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for silverstripe/silverstripe-admin#1252