Revisit JS linting

[emteknetnz]

It was decided to suppress new JS linting issues before the CMS 5 beta in this issue as it was causing CI failures when PR's were otherwise fine

We should work out what new rules we wish to keep and re-enable them. See the PRs linked from the above issue for the rules which were suppressed.

Acceptance criteria

• Each disabled linting rules have been reviewed and a concious decision has been made about whether to keep them or not.
• JS modules have been updated to pass all linting rules.

When deciding if a rule should be enabled consider

• Does the rule avoid common pitfalls that are likely to introduce errors in the code?
• Can the rule be fix with automated linting tools?
• Is the rule mostly stylistic and would require a lot of manual work to fix?

PRs

ESLint config

• NEW Turn on some ESLint rules eslint-config#17
• MNT Update version eslint-config#18

Fixed modules

• MNT ESLint Issues following rules from main and import libs #1532
• FIX ESLint issues silverstripe-asset-admin#1371
• MNT ESLint issues silverstripe-blog#714
• MNT ESLint issues silverstripe-campaign-admin#271
• MNT ESLint issues silverstripe-cms#2865
• MNT ESLint issues silverstripe-elemental-bannerblock#114
• MNT ESLint issues silverstripe-mfa#501
• MNT ESLint issues silverstripe-realme#114
• MNT ESLint issues silverstripe-session-manager#157
• MNT ESLint issues silverstripe-tagfield#248
• MNT ESLint issues silverstripe-totp-authenticator#125
• MNT ESLint issues silverstripe-versioned-admin#297
• MNT ESLint issues silverstripe-webauthn-authenticator#145
• MNT ESLint issues bringyourownideas/silverstripe-maintenance#198
• MNT ESLint issues cwp-agencyextensions#97
• MNT ESLint issues silverstripe-elemental#1070
• MNT ESLint issues symbiote/silverstripe-advancedworkflow#497

Update eslint version

• DEP Update eslint module bringyourownideas/silverstripe-maintenance#200
• DEP Update eslint module cwp-agencyextensions#98
• DEP Update eslint module silverstripe-elemental#1075
• DEP Update eslint module #1535
• DEP Update eslint module silverstripe-asset-admin#1373
• DEP Update eslint module silverstripe-blog#716
• DEP Update eslint module silverstripe-campaign-admin#273
• DEP Update eslint module silverstripe-cms#2868
• DEP Update eslint module silverstripe-contentreview#205
• DEP Update eslint module silverstripe-elemental-bannerblock#118
• DEP Update eslint module silverstripe-externallinks#104
• DEP Update eslint module silverstripe-frameworktest#145
• DEP Update eslint module silverstripe-gridfieldqueuedexport#84
• DEP Update eslint module silverstripe-login-forms#143
• DEP Update eslint module silverstripe-lumberjack#124
• DEP Update eslint module silverstripe-mfa#503
• DEP Update eslint module silverstripe-realme#115
• DEP Update eslint module silverstripe-segment-field#83
• DEP Update eslint module silverstripe-sitewidecontent-report#67
• DEP Update eslint module silverstripe-subsites#530
• DEP Update eslint module silverstripe-tagfield#250
• DEP Update eslint module silverstripe-totp-authenticator#128
• DEP Update eslint module silverstripe-userforms#1222
• DEP Update eslint module silverstripe-versioned-admin#299
• DEP Update eslint module silverstripe-webauthn-authenticator#147
• DEP Update eslint module symbiote/silverstripe-advancedworkflow#498
• DEP Update eslint module symbiote/silverstripe-multivaluefield#97

[GuySartorelli]

Related: #1437

[sabina-talipova]

List of eslint rules that using in CMS5.

[sabina-talipova]

As a solution you can use the Prettier to fix some minor eslint issues.