Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT ESLint issues #501

Merged
merged 1 commit into from
Jul 9, 2023
Merged

MNT ESLint issues #501

merged 1 commit into from
Jul 9, 2023

Conversation

sabina-talipova
Copy link
Contributor

Description

Turn on some of the ESLint.

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/5/turn-on-eslint-rules branch 2 times, most recently from 15f39a6 to 0d46670 Compare July 5, 2023 01:09
@sabina-talipova sabina-talipova marked this pull request as ready for review July 5, 2023 01:09
@sabina-talipova sabina-talipova mentioned this pull request Jul 5, 2023
Closed
2 tasks
@emteknetnz emteknetnz dismissed a stale review July 5, 2023 05:00

Changed my thinking

emteknetnz
emteknetnz requested changes Jul 6, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit and PR prefix from FIX to MNT

@sabina-talipova sabina-talipova changed the title FIX ESLint issues MNT ESLint issues Jul 7, 2023
@emteknetnz emteknetnz merged commit 8a8fe70 into silverstripe:5 Jul 9, 2023
11 checks passed
@emteknetnz emteknetnz deleted the pulls/5/turn-on-eslint-rules branch July 9, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sabina-talipova @emteknetnz