Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT ESLint Issues following rules from main and import libs #1532

Merged

Conversation

sabina-talipova
Copy link
Contributor

Description

Turn on some of the ESLint.

Related PR

Parent issue

@sabina-talipova sabina-talipova mentioned this pull request Jun 27, 2023
2 tasks
@sabina-talipova sabina-talipova force-pushed the pulls/2/turn-on-eslint-rules branch 2 times, most recently from dee8d03 to f363c33 Compare July 3, 2023 03:05
@sabina-talipova sabina-talipova marked this pull request as ready for review July 3, 2023 03:07
@sabina-talipova sabina-talipova force-pushed the pulls/2/turn-on-eslint-rules branch 2 times, most recently from e101022 to c3051d9 Compare July 4, 2023 21:12
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict with the bundle - you'll need to rebase and run yarn build

Also realised this PR has the wrong prefix, please use MNT rather than FIX.

@sabina-talipova sabina-talipova force-pushed the pulls/2/turn-on-eslint-rules branch 2 times, most recently from 2dea137 to c661ef8 Compare July 7, 2023 03:52
@sabina-talipova sabina-talipova changed the title FIX ESLint Issues following rules from main and import libs MNT ESLint Issues following rules from main and import libs Jul 7, 2023
@emteknetnz emteknetnz merged commit db4c91a into silverstripe:2 Jul 9, 2023
11 checks passed
@emteknetnz emteknetnz deleted the pulls/2/turn-on-eslint-rules branch July 9, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants