Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Delay entwine onmatch until DOMContentLoaded (fixes #1469) #1476

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

kinglozzer
Copy link
Member

See #1469 for more info

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as advertised - just a couple of changes to make to the doc comments plus the CI failure

thirdparty/jquery-entwine/jquery.entwine.js Outdated Show resolved Hide resolved
@kinglozzer
Copy link
Member Author

Not sure why bundle.js changed, I’ve re-run the build on a different computer and it seems to now be correct

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! Merge on green.

@GuySartorelli GuySartorelli merged commit 1152031 into silverstripe:1.12 Mar 17, 2023
@GuySartorelli
Copy link
Member

Tagged as 1.12.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants