Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE / sanitiseShortCodeProperties is not a function #1012

Closed
thats4shaw opened this issue Sep 25, 2019 · 5 comments
Closed

TinyMCE / sanitiseShortCodeProperties is not a function #1012

thats4shaw opened this issue Sep 25, 2019 · 5 comments

Comments

@thats4shaw
Copy link

When inserting an image through TinyMCE you are now greeted with the following error:

TypeError: (0 , g.sanitiseShortCodeProperties) is not a function

Affects SilverStripe 4.4.4.

I also believe this is a problem in https://github.com/silverstripe/silverstripe-admin/ as same error appears when saving a page with a HTMLEditorField with images.

@dnsl48 dnsl48 changed the title Inserting image through TinyMCE throws sanitisation error TinyMCE / sanitiseShortCodeProperties is not a function Sep 25, 2019
@dnsl48
Copy link
Contributor

dnsl48 commented Sep 25, 2019

Accidentally incorrect versions of silverstripe/admin were tagged as 1.4.4 and 1.3.5.
This has been caused by issues with our release tooling.

We have fixed the tags as soon as we've been notified by our CI tooling. Unfortunately, the incorrect tags have been published for some time (overnight).

You seem to be among those who have been unlucky enough to pull the incorrect update.
Sorry for that 😅

To resolve the issue the correct version of the silverstripe/admin module should be installed, which are:

  • 1.4.4 : a3eaf95bb2e37641d5a2f476807cc9696d55fac4
  • 1.3.5 : 6e6fa5c618b9dbf4cc0a56704834bfa1d5b0d18e

composer update should fix that

@xyphoid
Copy link

xyphoid commented Sep 25, 2019

Cheers - composer update after trashing the vendor folder gets correct versions of this.

@maxime-rainville
Copy link
Contributor

So is there anything else to do to address this?

@thats4shaw
Copy link
Author

Sorted from my perspective - thanks for the quick turnaround!

@dnsl48
Copy link
Contributor

dnsl48 commented Sep 25, 2019

I've modified the issue title so others should be able to find this issue easily.
The solution is composer update
Explanation is posted above

@dnsl48 dnsl48 closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants