npm install on framework to fix builds #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @assertchris and @sminnee to be potential reviewers |
- babel needs to transform ES6 test files - it tries to find a babel config (in `.babelrc` or `package.json`) for each file its loading - at some point during test exec, it its the first ES6 file in framework (`../framework/admin/client/src/lib/SilverStripeComponent.js`) - goes up the directory, finds `framework/package.json` - tries to load ES6 module dependencies in that file relative to that - fails with `Couldn't find preset "react" relative to directory "/Users/ingo/builds/ss/framework"` - because we haven’t run `npm install` on `framework` (since its a asset-admin build) This is a short-term fix, we need to look into publishing node_modules instead of hacking around with NODE_PATH across SS modules.
chillu
force-pushed
the
pulls/fix-build-install-on-framework
branch
from
f419582
to
172ed38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.babelrcorpackage.json) for each file its loading../framework/admin/client/src/lib/SilverStripeComponent.js)framework/package.jsonCouldn't find preset "react" relative to directory "/Users/ingo/builds/ss/framework"npm installonframework(since its a asset-admin build)This is a short-term fix, we need to look into publishing
node_modules instead of hacking around with NODE_PATH
across SS modules.