Force a ?flush=1 on first test run in browser

[chillu]

Otherwise tests fail in a very unfriendly fashion. And given that CLI and web don't share the same cache folders, a sake dev/build flush=1 won't fix this either. Keep performance in mind though.

[sminnee]

This might also be because we're using the same folder on our buildslave to run multiple projects. Let's try fixing that first, as this seems like a little bit of a hack.

[phptek]

@chillu I come across cache-dir related issues all the time, and I'm sure I've encountered scenarios where some aspect of the F/S cache isn't cleared by flush= and I need to manually blow away the cache dir entirely - so for a bootstrapped env in which behat is running, couldn't you manually recursively delete the cache dir prior to the test run or just run behat via the webserver user?

sudo -u www-data ./framework/sake dev/build flush=all

[tractorcow]

@phptek you are right in that we don't trigger a delete on caches on flush; We could do a hard-reset of TEMP_DIR on flush, that that may be a little risky.

How about a flush request processor that iterates all cache definitions in config, and invokes clear() on them?

e.g.

---
Name: cmscache
After:
  - '#corecache'
---
SilverStripe\Core\Injector\Injector:
  Psr\SimpleCache\CacheInterface.CMSMain_SiteTreeHints:
    factory: SilverStripe\Core\Cache\CacheFactory
    constructor:
      namespace: "CMSMain_SiteTreeHints"

Could be cleared with:

class CacheFlushHandler implements Flushable {
	public function flush()
	{
		$config = Config::inst()->get(Injector::class);
		foreach ($config as $name => $definition) {
			if (strtok($name, '.') === CacheInterface::class) { 
				$cache = Injector::inst()->get($name);
				$cache->clear();
			}
		}
	}
}

[phptek]

@tractorcow while that might work, and not wanting to irk the crowd, but the original problem to me sounds like something that may best be "fixed" by bootstrapping the environment first, i.e. in calling code or in build pipelines.

[dhensby]

This issue concerns running tests through the browser, which can't be done anymore...

[tractorcow]

@dhensby I initially commented on that too, but this is behat not phpunit.

[dhensby]

Whoops

[phptek]

This issue concerns running tests through the browser, which can't be done anymore...

Whoops...