Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating composer to pull in PHPUnit 4.1 #52

Closed
wants to merge 1 commit into from
Closed

Updating composer to pull in PHPUnit 4.1 #52

wants to merge 1 commit into from

Conversation

halkyon
Copy link

@halkyon halkyon commented Jun 17, 2014

First step in getting silverstripe/silverstripe-framework#3119 fixed.

Please merge this one first, then the framework change above.

@tractorcow
Copy link

@halkyon how about we merge this into "develop" branch, and then we run the subsequent pull requests in cms and framework against this branch by tweaking .travis.yml temporarily? It would allow us to run a full suite compatibility check against our core modules prior to merging into the main 3.1 / master branches. This is how I tested the upgrade to mink 1.6.

I've created a develop branch for you if you want to try this out.

@halkyon
Copy link
Author

halkyon commented Jun 17, 2014

@tractorcow Good idea. I'll merge it in and do another pull request for behat and another temporary one for framework/.travis.yml. Might need to modify the travis-support module though, as it only pulls in behat-extension at composer version "*", but worth doing this anyway for testing more experimental changes to the behat module :)

@tractorcow
Copy link

Perhaps if you temporarily add the behat-extension: dev-develop to the framework composer.json it might exist peacefully with the requirement in travis-support?

@halkyon
Copy link
Author

halkyon commented Jun 17, 2014

@tractorcow silverstripe/silverstripe-travis-support#6

Once the above is merged, this can be tested: silverstripe/silverstripe-framework#3214

@tractorcow
Copy link

I've merged the travis support module PR. Let me know if you need anything else.

@chillu
Copy link
Member

chillu commented Aug 11, 2014

Copying comment from silverstripe/silverstripe-framework#3119

I think this is blocked until we upgrade to Behat 3.0. The Behat version we're currently relying on (2.5) is setting "phpunit/phpunit": "~3.7.19" (https://github.com/Behat/Behat/blob/2.5/composer.json#L29). And updating Behat is a larger effort (days rather than hours I think). @jeffreyguo has made a start on this update I think.

@chillu chillu mentioned this pull request Sep 1, 2014
8 tasks
@chillu
Copy link
Member

chillu commented Sep 1, 2014

Since this can't be actioned anytime soon, I'm going to close the PR. Tracked the upgrade activity as a task on #62

@chillu chillu closed this Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants