Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update SapphireTest to match phpunit 4 #3119

Closed
wants to merge 1 commit into from

Conversation

sminnee
Copy link
Member

@sminnee sminnee commented May 9, 2014

This appears to be the only change necessary to get the tests building on phpunit 4. We'll see if the pull requests fails build on another phpunit...

@simonwelsh
Copy link
Contributor

This breaks Behat, since it'll need to pull in PHPUnit 4 as well.

@chillu
Copy link
Member

chillu commented Aug 2, 2014

I think this is blocked until we upgrade to Behat 3.0. The Behat version we're currently relying on (2.5) is setting "phpunit/phpunit": "~3.7.19" (https://github.com/Behat/Behat/blob/2.5/composer.json#L29). And updating Behat is a larger effort (days rather than hours I think). @jeffreyguo has made a start on this update I think.

@tractorcow
Copy link
Contributor

Good spot @chillu. I knew it wouldn't be a trivial task.

@tractorcow
Copy link
Contributor

@chillu Should we perhaps aim for 3.2 for behat 3 / phpunit 4 support?

@chillu
Copy link
Member

chillu commented Aug 3, 2014

Behat 3 upgrade progress is tracked here, its a PITA: silverstripe/silverstripe-behat-extension#62. Aiming for 3.2 sounds reasonable though

@simonwelsh
Copy link
Contributor

This can be pulled safely just without the composer change. I suggest that @sminnee removes that change, then this can be merged so that PHPUnit 4 can be used with E_STRICT enabled (the HHVM framework tests use PHPUnit 4, though seem to have E_STRICT off).

@chillu
Copy link
Member

chillu commented Aug 11, 2014

This has been fixed through 19e0d5e already (without pulling in the composer change)

@chillu chillu closed this Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants