PubDate in RSS feed is wrong

[ksdhans]

The date that ends up in the RSS feed is the post's creation date, and not its publish date. I've worked around this by creating a custom RSSFeed.ss template that replaces:
<% if $Date %>$Date.Rfc822
<% else %>$Created.Rfc822<% end_if %>

with the following:
<% if $PublishDate %>$PublishDate.Rfc822
<% else_if $Date %>$Date.Rfc822
<% else %>$Created.Rfc822<% end_if %>

This works, but it would be better if it worked correctly out of the box.

[dhensby]

Would you mind opening a PR?

[ksdhans]

Not so fast. I could transfer my RSSFeed.ss changes to the main RSSFeed.ss, but that's in silverstripe-framework, and not the blog module. Is modifying RSSFeed.ss in the core really the correct solution for a blog problem?

[dhensby]

You can add a template to another module and it should override the framework one

[micmania1]

I think we'll need a separate template for this. If we overwrite the existing template in Blog then it will affect all RSS feeds which isn't what we want.

If you can create/copy the RSS template from framework to a custom template (ie. BlogRssFeed.ss) in blog, but with the date updated to PublishDate then you can use `$rss->setTemplate('BlogRssFeed') here: https://github.com/silverstripe/silverstripe-blog/blob/master/code/model/Blog.php#L1052

[ksdhans]

What about adding a getDate() method that returns PublishDate? RSSFeed.ss will use Date if it exists.

[dhensby]

Either of those suggestions are good.

[tractorcow]

What about adding a getDate() method that returns PublishDate? RSSFeed.ss will use Date if it exists.

Please PR anyone. :)

[micmania1]

See #403