BUG Fix issue with populateDefault breaking during dev/build #140
Conversation
|
sorry, I've been sitting on #135 for a while and not had time to get round it. Unfortunately the test is fragile and needs sorting out and I've just not had the time to spend on it... |
|
Ah, sorry @dhensby. I made a late night fix without checking the other pull requests first. :) |
|
@tractorcow so what's causing these travis failures? |
|
composer/composer#3480 needs merging :) |
|
@tractorcow whilst that takes its time being pulled in, is there any work around so we can get passing tests? |
|
Then we have to make a call on whether or not we can dismiss the travis failures for the time being, in order to allow further pull requests to be merged. We've done it before in the past (e.g. during the big ORM rewrite debacle). What does your better judgement tell you? :) |
|
Well, I think this looks like a sensible fix, but we still have a problem despite that PR to composer being merged because there are too many satisfiable SS modules. Perhaps we need to enforce that we only test against stable releases? |
BUG Fix issue with populateDefault breaking during dev/build
Fixes #139