FIX Remove non-alphanumeric characters from the readable field name

silverstripe · Dec 13, 2018 · a885b5d · a885b5d
1 parent b56d673
commit a885b5d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Service/ResourceFieldPopulator.php b/src/Service/ResourceFieldPopulator.php
@@ -107,6 +107,9 @@ protected function parseName($id)
         // Swap out certain characters with spaces
         $name = str_replace(['_', '-'], ' ', $name);
 
+        // Remove non-alphanumeric characters
+        $name = trim(preg_replace('/[^\w\s]/', '', $name));
+
         return ucfirst($name);
     }
 

diff --git a/tests/Service/ResourceFieldPopulatorTest.php b/tests/Service/ResourceFieldPopulatorTest.php
@@ -41,7 +41,7 @@ public function testPopulate()
                 'type' => 'text',
             ],
             [
-                'id' => 'field_bar-captain',
+                'id' => 'field_bar-^captain',
                 'type' => 'select',
             ]
         ]);