Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase click-size of multi-selection button #1218

Merged
merged 1 commit into from Jun 17, 2015

Conversation

scott1702
Copy link
Contributor

Allows the entire multi-selection button to be clicked rather than just the text and the checkbox

<input id="view-mode-batchactions" name="view-mode-batchactions" type="checkbox" />
<label for="view-mode-batchactions"><% _t("CMSPagesController_ContentToolbar_ss.MULTISELECT","Multi-selection") %></label>
</div>
<span><% _t("CMSPagesController_ContentToolbar_ss.MULTISELECT","Multi-selection") %></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see silverstripe/silverstripe-framework#4293 (diff)

tl;dr Add a class to the span (view-mode-batchactions-label perhaps?)

dhensby added a commit that referenced this pull request Jun 17, 2015
Increase click-size of multi-selection button
@dhensby dhensby merged commit 5e9bce0 into silverstripe:3.1 Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants