Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update styles for multi-selection button #4293

Merged
merged 1 commit into from Jun 17, 2015

Conversation

scott1702
Copy link
Contributor

@@ -906,7 +906,7 @@ body.cms {
vertical-align: middle;
}

label {
span {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better to use a class rather than element selector, then when markup changes we won't have to change our CSS again

@scott1702
Copy link
Contributor Author

Good thinking @dhensby, Updated :)

dhensby added a commit that referenced this pull request Jun 17, 2015
Update styles for multi-selection button
@dhensby dhensby merged commit 4d85540 into silverstripe:3.1 Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants