API Allow SiteTree::Link to be extended #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
force-pushed
the
pulls/4.0/extend-link
branch
from
12f382b
to
38f3d1a
Compare
flamerohr
suggested changes
Sep 4, 2017
|
|
||
| public function updateLink(&$link, $action = null) | ||
| { | ||
| $link = Controller::join_links($link, '?extra=1'); |
There was a problem hiding this comment.
I'd like to see a unit test prepending to the link, to cover what you're intending for this extension point as well.
tractorcow
force-pushed
the
pulls/4.0/extend-link
branch
from
38f3d1a
to
a9c479f
Compare
|
Done @flamerohr :D |
flamerohr
approved these changes
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to allow post-baseurl applied links to be modified.
Useful for modules such as subsites / fluent which may need to prepend domain names.