Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use logInAs() for unit tests #2682

Merged
merged 1 commit into from
Aug 19, 2021
Merged

MNT Use logInAs() for unit tests #2682

merged 1 commit into from
Aug 19, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Aug 18, 2021
Closed
21 tasks
maxime-rainville
maxime-rainville approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Probably worth mentioning that some of the logOut calls are not necessary as the tests should implicitly log you out anyway in between calls.

@maxime-rainville maxime-rainville merged commit 5634173 into silverstripe:4 Aug 19, 2021
@maxime-rainville maxime-rainville deleted the pulls/4/fix-unit-tests branch August 19, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville