ENHANCEMENT Indicate which file extensions are allowed to be uploaded

[halkyon]

When uploading a file to a folder, show which file extensions are permitted to be uploaded through UploadField->getValidator()->getAllowedExtensions()

This is for http://open.silverstripe.org/ticket/6905

[sminnee]

Seems reasonable to me; does the UI look okay, though?

[halkyon]

There's quite a few extensions in the text, what do you think? http://postimage.org/image/87cw9ns6b/

[chillu]

Hmm, can we order them by most common, and provide a "..." after the first ~10 exensions? That'd be the icing on the cake though...

At the least they should be ordered alphabetically though, otherwise the list is actually quite useless hehe.

[chillu]

Can we move the HTML out of the _t() call? I know we tend to do that in core, but its not a great habit as it leaves too much room for error for translators.

[halkyon]

@chillu Woops, that's a good point. I'll update the commit.

On Tue, Mar 27, 2012 at 12:14 PM, Ingo Schommer <
reply@reply.github.com

wrote:

@@ -73,9 +73,13 @@ public function getEditForm($id = null, $fields =
null) {
}

          $form = new Form(

•                 $this,
  

•                 'getEditForm',
  

•                 new FieldList($uploadField, new HiddenField('ID')),
  

•                 $this,
  

•                 'getEditForm',
  

•                 new FieldList(
  

•                         $uploadField,
  

•                         new LiteralField('AllowedExtensions',
  

  sprintf('

  Allowed extensions: %s

  ', implode(', ',
  $uploadField->getValidator()->getAllowedExtensions()))),

Can we move the HTML out of the _t() call? I know we tend to do that in
core, but its not a great habit as it leaves too much room for error for
translators.

---

Reply to this email directly or view it on GitHub:
https://github.com/silverstripe/silverstripe-cms/pull/78/files#r606365

[halkyon]

I've added the correct _t() call to this now, and sorted the extensions alphabetically. The text "Allowed extensions" is now translatable independent of the formatting of the extension list.