FIX Correcting inconsistent capitalisation of label and cleaning up tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bels specifically added
NightJar
approved these changes
Jan 11, 2019
|
Yeah I saw that. My guess is that there's some translations that are still affecting this. I'll fix up the translation file to get the tests green. Kind of illustrates the volatility of that test seeing as the result is based on configuration (of translation strings). |
ScopeyNZ
force-pushed
the
pulls/3.1/i-de-test-those-labels
branch
from
1b83330
to
7691237
Compare
|
I've updated the PR 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the builds that run against the latest framework version as there was a recent change (silverstripe/silverstripe-framework#8698) that changes how labels are generated to have better casing. It does this by only testing the labels that are specifically specified.
Additionally this removes the unnecessary tests of the
i18nsystem.